docs(recipes): point chat_template at where the templates actually live - #2460
Conversation
modelopt_recipes/general/speculative_decoding/chat_templates/ does not exist -- this comment is the only reference to it anywhere in the tree. Each model keeps its template beside its launcher example instead. Signed-off-by: Ye Yu <yeyu@nvidia.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Ye Yu <yeyu@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe DFlash speculative decoding recipe updates its chat-template documentation. The comment now shows a model-specific template path beside the launcher YAML instead of a centralized directory. ChangesDFlash template documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only update does not change runtime behavior and is ready to merge. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@shengliangxu could you take a look? Two-line comment fix in a recipe YAML — it points at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
==========================================
+ Coverage 71.50% 78.97% +7.47%
==========================================
Files 590 590
Lines 64749 64748 -1
==========================================
+ Hits 46297 51133 +4836
+ Misses 18452 13615 -4837
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What does this PR do?
Type of change: Documentation
dflash.yamltells the reader that chat templates live inmodelopt_recipes/general/speculative_decoding/chat_templates/. That directory does not exist, and this comment is its only mention anywhere in the tree:Templates actually sit beside each launcher example —
tools/launcher/examples/Qwen/Qwen3-8B/chat_template_train.jinja,.../MiniMax/MiniMax-M2.7-DFlash/chat_template_train.jinja, and so on.Split out of #2201, where this two-line comment was the only reason
modelopt-recipes-codeownerswas a required reviewer on a skills-documentation PR.Usage
No behaviour change — comment only.
Testing
None needed; the file's only change is a YAML comment.
pre-commitpasses.Before your PR is "Ready for review"
CONTRIBUTING.md: N/A🤖 Generated with Claude Code
Summary by CodeRabbit