Add Llama to Puzzletron v2 - #2454
Draft
grzegorz-k-karch wants to merge 1 commit into
Draft
grzegorz-k-karch wants to merge 1 commit into
grzegorz-k-karch wants to merge 1 commit into
Conversation
Signed-off-by: Grzegorz Karch <gkarch@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/puzzletron_v2 #2454 +/- ##
=========================================================
- Coverage 50.63% 50.62% -0.01%
=========================================================
Files 713 713
Lines 94313 94320 +7
=========================================================
- Hits 47756 47752 -4
- Misses 46557 46568 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Enables Llama 3.1 8B Instruct pruning campaigns in Puzzletron v2 with minimal implementation changes:
Usage
With a prepared dataset and site-specific runner/execution configurations:
Remove
--dry-runto launch. Usepruneffn_memory_joint_sweep_smoke.yamlfor a reduced-cost pipeline check; smoke results are not accuracy-comparison results.Testing
Validated the isolated staged tree, excluding unrelated working-tree changes:
test_generic_decoder_converter.py,test_orchestration_lightweight.py, andtest_llama3p1_8b_pruneffn_memory_config.py.Before your PR is "Ready for review"
Follow the Contributor guidelines, including signed commits (
git commit -s -S), and [Security Best Practices](https://github.com/NVIDIA/Model-Optimizer/blob/main/SECURITY.md#security-coding-pract\ices-for-contributors).
CONTRIBUTING.md?: N/A — no new runtime dependencies or external code.Additional Information
Scope: commit
759dd8b51(11 files). Uses existing sweep infrastructure; no new sweep engine is introduced. Setup-wizard changes, depth-pool changes, and broader orchestration hardening are excluded.