Fix image calibration VAE decode crash - #2435
mikemikimike wants to merge 1 commit into
Conversation
Signed-off-by: mikemikimike <13286568797@163.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe calibration pipeline now requests latent outputs. A regression test verifies the prompt, inference-step count, latent output type, and avoidance of VAE decoding. ChangesCalibration latent output
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk: ⚪ Minimal · up to The calibration call uses latent output without a conflicting default argument, and focused regression coverage protects the request contract. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Request latent outputs during image-model calibration so VAE decoding is skipped. Add an offline regression test for the calibration call contract. Testing: pytest tests/examples/diffusers/test_calibration.py; pytest tests/unit tests/examples/diffusers/test_calibration.py; pre-commit run --all-files. Issue: #2424. Fixes #2424
Summary by CodeRabbit
Bug Fixes
Tests