Add (u)int32 TIFF fixtures for decoder testing - #136
Open
jantonguirao wants to merge 2 commits into
Open
jantonguirao wants to merge 2 commits into
jantonguirao wants to merge 2 commits into
Conversation
Same image as db/single/tiff/0/cat-300572_640.tiff, re-encoded with 32-bit unsigned integer samples, for testing 32-bit TIFF decoding.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jantonguirao
added a commit
to jantonguirao/DALI
that referenced
this pull request
Sep 29, 2026
Bumps DALI_EXTRA_VERSION to pick up the new db/single/tiff/0/cat-300572_640_uint32.tiff fixture (NVIDIA/DALI_extra#136).
4 of 18 tasks
Adds db/single/tiff/0/cat-300572_640_int32.tiff (signed 32-bit samples, SAMPLEFORMAT_INT) alongside the existing uint32 fixture, plus ground-truth .npy references for both under db/single/reference/tiff/0/, generated via tifffile.
jantonguirao
changed the title
jantonguirao
changed the title
jantonguirao
added a commit
to jantonguirao/DALI
that referenced
this pull request
Sep 29, 2026
Bumps DALI_EXTRA_VERSION to pick up the new db/single/tiff/0/cat-300572_640_uint32.tiff fixture (NVIDIA/DALI_extra#136). Signed-off-by: Joaquin Anton Guirao <janton@nvidia.com>
mdabek-nvidia
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
db/single/tiff/0/cat-300572_640_uint32.tiff— the same image as the existingcat-300572_640.tifffixture, re-encoded with 32-bit unsigned integer samples.Needed for a new test case in NVIDIA/DALI#6510, which fixes uint32 TIFF decoding (previously crashed with
Invalid sample_type: 8198).