fix(stirrup): restore tool messages for model calls#1277
Open
syadav481 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Open
fix(stirrup): restore tool messages for model calls#1277syadav481 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
syadav481 wants to merge 1 commit intoNVIDIA-NeMo:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NeMoUserMessagetool results back toToolMessagebefore normal OpenAI-compatible chat-completions model calls.tool_response_as_userbehavior while ensuring provider-facing payloads satisfy tool-call ordering rules.NeMoUserMessagetool results asfunction_call_outputin exported run history and keep call IDs stable.Why
#1181 fixed the summarization path, but normal Stirrup generation can still replay an assistant
tool_callsmessage followed by a user-roleNeMoUserMessagetool result into an OpenAI-compatible model server. Providers reject that payload because assistant tool calls must be followed by matching tool-role responses.Testing
./.venv/bin/python -m pytest responses_api_agents/stirrup_agent/tests/test_app.py responses_api_agents/stirrup_agent/tests/test_nemo_client.py -q./.venv/bin/ruff check responses_api_agents/stirrup_agent/nemo_agent.py responses_api_agents/stirrup_agent/nemo_client.py responses_api_agents/stirrup_agent/stirrup_utils.py responses_api_agents/stirrup_agent/tests/test_app.py responses_api_agents/stirrup_agent/tests/test_nemo_client.py