CVDP Resources Server Fixes for commercial tooling support #1276
Open
CVDP Resources Server Fixes for commercial tooling support #1276
Conversation
…pace Signed-off-by: Arti <artij@nvidia.com>
…vdp_commercial_fix
Signed-off-by: Arti Jain <artij@nvidia.com>
…. Default to '' instead of '/tmp' so extra host->container tmp bind and TMPDIR/XCELIUM_TMPDIR/CDS_LOCK/JAVA_TOOL_OPTIONS env injection only run when explicitly configured. Default behavior now matches upstream cvdp_benchmark (no extra mounts/env), while users hitting disk/permissions issues with default /tmp can opt in by setting the path. Also Gate rundir/tmp creation, --bind, and runtime tmp env vars on the config. Signed-off-by: Arti Jain <artij@nvidia.com>
…vdp_commercial_fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to CVDP resources_server/cvdp/app.py to add infra support for running commercial tooling. Fixes a file-placement bug in the harness workspace. Default behavior is unchanged from upstream cvdp_benchmark; new functionality is opt-in via config.
Fix: preserve target paths when writing harness files. _run_harness previously rewrote every context/RTL file into workdir/rtl/, which broke harnesses with files outside rtl/ (e.g. verif/tb_foo.sv, docs/...). Files are now written at their declared relative path, matching cvdp_benchmark's repository.restore_files() semantics.
New config: harness_workspace_dir (default ""). Optional host directory used as the parent for per-rollout temp workdirs. Useful when the system TMPDIR is small (e.g. tmpfs on HPC). Defaults to system tmp when unset.
New config: container_tmp_bind_path (default ""). When set (e.g. /tmp), creates rundir/tmp on the host, binds it into the container at this path, and injects TMPDIR/TMP/TEMP/TEMPDIR/XCELIUM_TMPDIR/CDS_LOCK/JAVA_TOOL_OPTIONS=-Djava.io.tmpdir=.... Required for Cadence Xcelium EDA tools, which otherwise hit a read-only or undersized /tmp and crash. Unset = no extra bind/env, matches upstream.
New helper _build_runtime_tmp_env_args() builds the env-var flag list for the case above.