Skip to content

chore: set up control repo for theme upload and edits#1885

Open
fern-support wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
fern-support:fern-support/global-theme-setup
Open

chore: set up control repo for theme upload and edits#1885
fern-support wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
fern-support:fern-support/global-theme-setup

Conversation

@fern-support
Copy link
Copy Markdown

@fern-support fern-support commented Apr 28, 2026

Establishes this repo as the "control" repo for theme upload and edits. Edit all canonical assets for thematic elements here, and then run fern docs theme upload --name nvidia when you'd like to push up edits to be hosted by Fern.

Children NVIDIA documentation repos can then simply inherit the thematic elements by specifying the global theme name nvidia in their docs.yml.

Full documentation: https://buildwithfern.com/learn/docs/customization/global-themes

@fern-support fern-support requested a review from a team as a code owner April 28, 2026 15:05
@fern-support fern-support requested review from praateekmahajan and removed request for a team April 28, 2026 15:05
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Apr 28, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR establishes the NeMo Curator repo as the Fern "control" repo for uploading and managing the shared nvidia global theme. It adds the theme package under fern/theme/ (SVG logos, CustomFooter.tsx, main.css, theme.yml) and updates fern/docs.yml to activate the global theme.

  • theme.yml sets logo.href: /nemo/curator/home/welcome and logo.right-text: NeMo Curator — these are product-specific values that will propagate to every child NVIDIA docs repo that inherits the nvidia global theme, causing the wrong logo link and label to appear on unrelated products.

Confidence Score: 4/5

Safe to merge for NeMo Curator itself, but theme.yml contains NeMo Curator-specific logo values that will break branding on other child repos the moment the theme is uploaded and inherited.

One P1 finding: logo.href and logo.right-text in the shared theme are product-specific; every other child repo inheriting the nvidia global theme will display NeMo Curator branding. This should be fixed before running fern docs theme upload --name nvidia.

fern/theme/theme.yml (product-specific logo values in a shared global theme)

Important Files Changed

Filename Overview
fern/docs.yml Reorganizes config: moves libraries/experimental before versions, adds global-theme section with nvidia theme, duplicates footer directive (intentionally overridden). Trailing whitespace on global-theme line (flagged previously).
fern/fern.config.json Bumps Fern CLI version from 4.43.1 to 4.103.1.
fern/theme/assets/components/CustomFooter.tsx New React footer component for the theme package; same logo URL for both light/dark variants (previously flagged) — relies on CSS invert(1) for light mode.
fern/theme/assets/main.css Full NVIDIA theme CSS; contains an unstable Figma MCP asset URL as a mask-image (previously flagged) which may break the landing-gradient-bottom visual.
fern/theme/theme.yml Defines the global nvidia theme; logo.href and logo.right-text are NeMo Curator-specific and will render incorrectly for all other NVIDIA child repos that inherit this shared theme.

Comments Outside Diff (1)

  1. fern/theme/theme.yml, line 1186-1187 (link)

    P1 Product-specific values in a shared global theme

    logo.href and logo.right-text are set to NeMo Curator-specific values (/nemo/curator/home/welcome and NeMo Curator). Because this file is uploaded as the shared nvidia global theme, every child documentation repo that inherits it will also display "NeMo Curator" as the logo label and link to the NeMo Curator home path — which is clearly wrong for e.g. NeMo Framework or any other NVIDIA product site. These fields should be left unset (or set to a product-agnostic default) in the shared theme and overridden per-child-repo in each child's docs.yml.

Reviews (2): Last reviewed commit: "Merge branch 'main' into fern-support/gl..." | Re-trigger Greptile

Comment on lines +827 to +834
.hero-column-title {
font-size: 20px;
}

.hero-column-subtitle {
font-size: 14px;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Ephemeral Figma MCP asset URL used as mask-image

https://www.figma.com/api/mcp/asset/... is a Figma MCP API path that is not a stable public CDN URL — it may expire with the session, become inaccessible due to CORS, or disappear when the asset is moved. When this URL fails, the mask-image silently has no effect, breaking the .landing-gradient-bottom visual. Replace it with a self-hosted or CDN-hosted SVG asset (e.g. alongside the other NVIDIA SVGs in fern/theme/assets/assets/).

@lbliii lbliii requested review from arhamm1 and lbliii April 28, 2026 19:37
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the waiting-on-maintainers Waiting on maintainers to respond label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-request waiting-on-maintainers Waiting on maintainers to respond

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants