Repository navigation
Check the walltime deadline during gather and child waits - #48
Merged
Merged
Conversation
…g on child processes; bump version to 3.0.16 The deadline guard was only reachable from the per-item work loops, so a run that spent its last hour gathering datasets or waiting on the final tar children never parked a progress report and the walltime kill looked silent. Adds the guard to the three gather loops and replaces the blocking check_child(..., dowait=1) calls with wait_all_children(), which polls with dowait 0 so the deadline is checked between polls. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_child(..., dowait=1)waiting on the final tar children, never reachedcheck_batch_deadline()- so the PBS kill produced no progress report at all.wait_all_children()replaces the three blockingcheck_child(..., dowait=1)calls; it polls withdowait 0and sleeps viashow_wait_message, keeping the same cadence while checking the deadline between polls.Test plan
ast.parseclean;check_child/show_wait_messagesignatures verified against pg_sig.py