Repository navigation
Fix the missing PBS progress report, the progress line and stalled-worker detection - #46
Merged
Merged
Conversation
dcount/fcount; judge a stalled worker on its rate; bump version to 3.0.14 The walltime guard was only reached where a tar was actually dispatched, so a long stretch of skipped files walked past the cutoff without parking a progress report - a 23h run reported nothing. The tar queue depths also read as almost done while building was the busy phase, and a job at 2% cleared the absolute 1% stall threshold and so never got a second worker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_batch_deadline()was only reached fromprocess_one_backup_file()andtransfer_quasar_tarfiles(), i.e. only where a tar was actually dispatched. Everycontinueabove the dispatch skipped it, so a long stretch of skipped files walked past the walltime cutoff without ever parking a report. It is now called from the top of all four per-item loops.-A 3tars each input file right after creating it, so theNcount stays near zero exactly while building is the busy phase. Newbatch_done_count()reportsdcount/fcountinstead.worker_progress_stalled()used an absolute done fraction (MINWDONE = 0.01), so a job at 2% read as progressing and never got a second worker even though it projected to ~28 days. Now rate based:MINWPROJ = 0.9, stalled whendone*WALLTIME/elapsed < MINWPROJ.Test plan
python3 -m py_compilecleanbatch_done_count()reproduces the livedscheck gcnumbers (130927<:>2604->2604 of 130927 file(s) done(1%))-A 3batch run send a progress report with the new lineGenerated with Claude Code