Repository navigation
Cache a progress report in dscheck.einfo before the PBS walltime - #43
Merged
Merged
Conversation
…p version to 3.0.12 A long -A 3 or -A 4 batch run was killed by PBS before start_actions() reached its email block, so no report was ever sent. Rather than cut the work short to make time for the mail, the run now parks a progress report in dscheck.einfo an hour before the walltime and keeps going: the dscheck daemon mails that report once the record is unlocked, and a run that does finish overwrites it with the full report so only one mail goes out. The walltime is read back from PBS (qstat ReqdTime) instead of assumed, since the dscheck daemon caps the requested 24 hours to the maximum of the queue the job lands in. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-A 3/-A 4batch run was killed by PBS beforestart_actions()reached its email block, so no report was ever sent. The run now caches a progress report intodscheck.einfoan hour before the walltime and keeps working; the dscheck daemon mails it once the record is unlocked (after a kill or a normal finish).qstatReqdTime) instead of assumed, since the dscheck daemon caps the requested 24 h to the maximum of the queue the job lands in (only 6 h fordefault).Test plan
python3 -m py_compile src/rda_python_dsquasar/dsquasar.pyget_pbs_info()returns{}on failure and that theReqdTimekey is produced (pg_sig.py:919)build_customized_email()sends first and only caches on failure, socache_customized_email()is required to park a report (pg_dbi.py:2190/2277)einfowhenpid = 0(pg_check.py:436/455), so a cached report is not mailed while the job still runscheck_batch_deadline()callers run in the parent only (childrensys.exit()at dsquasar.py ~922/~1014)Generated with Claude Code