Report the newest member time for object store directory keys - #125
Merged
Merged
Conversation
…bump version to 3.0.17 check_object_file() took the timestamp of whichever member the listing happened to return first for a key prefix such as a zarr store. The newest member's timestamp is reported instead, which is what the file as a whole was last modified at. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_object_file()reported the timestamp of whichever member the listing happened to return first for a key prefix such as a zarr store. It now reports the newest member's timestamp, which is what the store as a whole was last modified at.Note
LastModifiedis zero padded ISO, so a plain max over the listing is chronological. Thecnt/isdircomputation moved above theobject_file_stat()call so the right member can be picked; the rest of the branch is unchanged. Single object keys behave exactly as before.Side effect: with
opt&32a directory key'schecksumnow comes from the newest member's ETag rather than the first member's. Neither is meaningful for a store and no current caller asks for a checksum on a directory key.Test plan
py_compilecleanisfile=0; single object key unchanged-A 3on d694517; expect one round of Timestamp mismatch lines as stored values are corrected