Skip to content

Report the newest member time for object store directory keys - #125

Merged
zaihuaji merged 1 commit into
mainfrom
hua-work-common
Sep 17, 2026
Merged

zaihuaji merged 1 commit into
mainfrom
hua-work-common

Conversation

@zaihuaji

Copy link
Copy Markdown
Collaborator

Summary

  • check_object_file() reported the timestamp of whichever member the listing happened to return first for a key prefix such as a zarr store. It now reports the newest member's timestamp, which is what the store as a whole was last modified at.
  • Version bumped to 3.0.17.

Note

LastModified is zero padded ISO, so a plain max over the listing is chronological. The cnt/isdir computation moved above the object_file_stat() call so the right member can be picked; the rest of the branch is unchanged. Single object keys behave exactly as before.

Side effect: with opt&32 a directory key's checksum now comes from the newest member's ETag rather than the first member's. Neither is meaningful for a store and no current caller asks for a checksum on a directory key.

Test plan

  • py_compile clean
  • Stubbed listing: directory key returns the newest of three member timestamps, summed size and isfile=0; single object key unchanged
  • Rerun dsquasar -A 3 on d694517; expect one round of Timestamp mismatch lines as stored values are corrected

…bump version to 3.0.17

check_object_file() took the timestamp of whichever member the listing
happened to return first for a key prefix such as a zarr store.  The
newest member's timestamp is reported instead, which is what the file as
a whole was last modified at.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 17, 2026 14:11
@zaihuaji
zaihuaji merged commit e0c9e47 into main Sep 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant