pg_file.py: wait for Globus task completion on Quasar copies; bump ve… - #118
Merged
Merged
Conversation
…rsion to 3.0.10 backup_copy_local() returned the FINISH status of a still-active dsglobus transfer, so callers such as dsarch's Quasar restore treated a partially downloaded tar file as complete. It now blocks until the task reports SUCCEEDED. copy_gdex_file() has the same problem for uploads and none of its callers handle FINISH, so its backup branches go through the new wait_copy_backup() helper; local_copy_backup() is left as is because dsarch and dsquasar wait on their own. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a correctness issue in Quasar (Globus) copy operations where a still-active transfer could return FINISH, leading callers to treat partially transferred files as complete. It updates the Quasar copy paths to block until the Globus task reports SUCCEEDED, and bumps the package version accordingly.
Changes:
- Route local→Quasar backup uploads in
copy_gdex_file()through a newwait_copy_backup()helper so callers don’t receiveFINISH. - Update
backup_copy_local()to wait for Globus task completion before returning. - Bump project version from
3.0.9to3.0.10.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rda_python_common/pg_file.py | Adds a wait-for-completion helper and ensures Quasar Globus transfers complete before returning success to callers. |
| pyproject.toml | Bumps library version to reflect the behavioral fix. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rsion to 3.0.10
backup_copy_local() returned the FINISH status of a still-active dsglobus transfer, so callers such as dsarch's Quasar restore treated a partially downloaded tar file as complete. It now blocks until the task reports SUCCEEDED. copy_gdex_file() has the same problem for uploads and none of its callers handle FINISH, so its backup branches go through the new wait_copy_backup() helper; local_copy_backup() is left as is because dsarch and dsquasar wait on their own.