pg_log.py: remove duplicate SETPGLOG, drop PG* env var prefix; bump v… - #116
Merged
Merged
Conversation
…ersion to 3.0.7 Commit 28ade60 added a second SETPGLOG(self, key, default) near the top of class PgLOG, unaware of the existing SETPGLOG(self, name, value='') defined later in the class. Python kept the later definition, so the added one was dead code and its PGCOMMONUSER/PGADMINUSER contract never took effect. Remove the dead definition and correct the two comments that documented the non-existent PG* prefix. COMMONUSER/ADMINUSER are read from the bare-named environment variables, consistent with every other key in the class. PgLOG.py is intentionally left unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a dead/duplicated SETPGLOG method definition in pg_log.py (so only the intended implementation remains), updates comments to reflect that COMMONUSER/ADMINUSER are read from bare environment variable names (not PG*-prefixed), and bumps the project version.
Changes:
- Remove the duplicate (dead)
SETPGLOG(self, key, default)definition fromPgLOG. - Update comments/documentation in
pg_log.pyto referenceCOMMONUSER/ADMINUSERenv vars (noPGprefix). - Bump package version in
pyproject.tomlto3.0.7.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/rda_python_common/pg_log.py | Removes dead duplicate method and corrects env-var prefix comments for COMMONUSER/ADMINUSER. |
| pyproject.toml | Bumps project version to 3.0.7. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [project] | ||
| name = "rda_python_common" | ||
| version = "3.0.6" | ||
| version = "3.0.7" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ersion to 3.0.7
Commit 28ade60 added a second SETPGLOG(self, key, default) near the top of class PgLOG, unaware of the existing SETPGLOG(self, name, value='') defined later in the class. Python kept the later definition, so the added one was dead code and its PGCOMMONUSER/PGADMINUSER contract never took effect.
Remove the dead definition and correct the two comments that documented the non-existent PG* prefix. COMMONUSER/ADMINUSER are read from the bare-named environment variables, consistent with every other key in the class. PgLOG.py is intentionally left unchanged.