bump version to 3.0.5 - #114
Merged
Merged
Conversation
Try .pgpass before OpenBao for db password lookup; suppress per-method error logging so a working fallback doesn't surface noise from the other
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the PostgreSQL credential lookup flow in pg_dbi.py to prefer .pgpass before OpenBao and reduces noisy error logging from fallback mechanisms, alongside a package version bump to 3.0.5.
Changes:
- Reordered password lookup to try
.pgpassbefore OpenBao, and added a single log when no credential source succeeds. - Suppressed exception logging inside
.pgpassand OpenBao readers to avoid noise when fallbacks succeed. - Bumped project version from 3.0.4 to 3.0.5.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rda_python_common/pg_dbi.py | Adjusts credential lookup order and changes exception/logging behavior for .pgpass and OpenBao reads. |
| pyproject.toml | Bumps package version to 3.0.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
2679
to
+2683
| if not line or line.startswith("#"): continue | ||
| dbhost, dbport, dbname, lnname, pwname = line.split(":") | ||
| self.DBPASS[(dbhost, dbport, dbname, lnname)] = pwname | ||
| except Exception as e: | ||
| self.pglog(str(e), self.PGDBI['ERRLOG']) | ||
| except Exception: | ||
| pass |
Comment on lines
2707
to
+2709
| ) | ||
| except Exception as e: | ||
| return self.pglog(str(e), self.PGDBI['ERRLOG']) | ||
| except Exception: | ||
| return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try .pgpass before OpenBao for db password lookup; suppress per-method error logging so a working fallback doesn't surface noise from the other