Hua work common - #106
Merged
Merged
Hua work common#106
Conversation
Adds [tool.setuptools.package-data] so pgpassword.usg (and any future .usg files) are bundled into the built wheel/sdist and installed alongside the package. Bumps version to 2.1.9 in pyproject.toml, __init__.py, and README. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously running pgpassword with no arguments triggered the usage display, so users could not get the password using all defaults. The no-args path now falls through to start_actions(), which performs the lookup with the PgDBI/PgLOG defaults (rdadb/dssdb/etc.). Usage is now requested explicitly via -?, -help, or --help. Also detects an option supplied without its required value (e.g. -d with nothing after it) and reports it as an error instead of silently falling into the help path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps the package version to 2.1.9 and refines the pgpassword CLI: explicit -?/-help/--help support, stricter validation for stray/missing option values, packaging of .usg usage files, and corresponding documentation/usage-file updates.
Changes:
- Add
-?/-help/--helphandling and detect missing option values; remove the "no args ⇒ show usage" behavior so defaults are used instead. - Ship
*.usgfiles as package data and bump version to 2.1.9 inpyproject.toml,__init__.py, andREADME.md. - Update
pgpassword.usgand theread_parametersdocstring to reflect the new behavior; fixexcecutetypo.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/rda_python_common/pgpassword.py | Adds help-flag handling, missing-value detection, improved error messages; fixes "excecute" typo. |
| src/rda_python_common/pgpassword.usg | Documents -?/--help and updated no-arg behavior. |
| src/rda_python_common/init.py | Version bump to 2.1.9. |
| pyproject.toml | Version bump and includes *.usg as package data. |
| README.md | Updates referenced installed version to 2.1.9. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.