Fix image-size DoS vulnerability (GHSA-w3rx-r6r6-pgpr) by dropping it via less upgrade - #273
Merged
Merged
Conversation
…ndency) Co-authored-by: smokhov <10067003+smokhov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix image-size denial of service vulnerability in ICNS parser
Fix image-size DoS vulnerability (GHSA-w3rx-r6r6-pgpr) by dropping it via less upgrade
Sep 2, 2026
Co-authored-by: smokhov <10067003+smokhov@users.noreply.github.com>
smokhov
marked this pull request as ready for review
September 2, 2026 01:34
smokhov
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot flagged
image-size@0.5.5for a high-severity DoS (CVE-2025-71330): a crafted ICNS buffer with a zero-valued entry length triggers an infinite loop in its parser, blocking the Node.js event loop.Why not a direct version bump
image-sizerelease (0.3.0 → 2.0.2, latest) is vulnerable per the advisory (first_patched_version: null); no fixed version exists to upgrade to.Fix
image-sizewas only present transitively as an optional dependency ofless@4.6.7(viafomantic-uiand@angular-devkit/build-angular).less@4.7.0+replacedimage-sizewithprobe-image-size, so pinninglessupward removes the vulnerable package from the tree entirely."less": "^4.9.0"to the existingoverridesblock insrc/java/ws/rest-client/package.json(consistent with existing pins for other transitive security fixes), compatible with all consumers' declared ranges.package-lock.json;image-sizeno longer resolves anywhere in the tree.Reachability assessment (high confidence: not reachable)
The vulnerable ICNS parsing path is only reachable through
less'sdata-uri()function. No.lessfile in this repo (including the bundledfomantic-uisource) callsdata-uri(, and thefomantic-uiLESS build isn't invoked by this project's own build/lint pipeline. The vulnerable code path was never exercised in practice — this change primarily satisfies the vulnerability scanner.Original prompt