Skip to content

Fix image-size DoS vulnerability (GHSA-w3rx-r6r6-pgpr) by dropping it via less upgrade - #273

Merged
smokhov merged 3 commits into
integrationfrom
copilot/fix-image-size-dos-vulnerability
Sep 2, 2026
Merged

Fix image-size DoS vulnerability (GHSA-w3rx-r6r6-pgpr) by dropping it via less upgrade#273
smokhov merged 3 commits into
integrationfrom
copilot/fix-image-size-dos-vulnerability

Conversation

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Dependabot flagged image-size@0.5.5 for a high-severity DoS (CVE-2025-71330): a crafted ICNS buffer with a zero-valued entry length triggers an infinite loop in its parser, blocking the Node.js event loop.

Why not a direct version bump

  • Every published image-size release (0.3.0 → 2.0.2, latest) is vulnerable per the advisory (first_patched_version: null); no fixed version exists to upgrade to.
  • No workaround section in the advisory either.

Fix

  • image-size was only present transitively as an optional dependency of less@4.6.7 (via fomantic-ui and @angular-devkit/build-angular).
  • less@4.7.0+ replaced image-size with probe-image-size, so pinning less upward removes the vulnerable package from the tree entirely.
  • Added "less": "^4.9.0" to the existing overrides block in src/java/ws/rest-client/package.json (consistent with existing pins for other transitive security fixes), compatible with all consumers' declared ranges.
  • Regenerated package-lock.json; image-size no longer resolves anywhere in the tree.

Reachability assessment (high confidence: not reachable)

The vulnerable ICNS parsing path is only reachable through less's data-uri() function. No .less file in this repo (including the bundled fomantic-ui source) calls data-uri(, and the fomantic-ui LESS build isn't invoked by this project's own build/lint pipeline. The vulnerable code path was never exercised in practice — this change primarily satisfies the vulnerability scanner.

Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>image-size: ICNS parser allows denial of service through an infinite loop</alert_title>
<alert_description>image-size through 2.0.2 contains a denial of service vulnerability that allows remote attackers to permanently block the Node.js event loop by supplying a specially crafted ICNS image buffer. Attackers can craft an ICNS buffer containing valid magic bytes and a zero-valued entry length field to trigger an infinite loop in the ICNS parser, as the offset is never incremented when the entry length field is 0, causing the while loop condition to remain true indefinitely.</alert_description>

high
GHSA-w3rx-r6r6-pgpr, CVE-2025-71330
image-size
npm
<vulnerable_versions>0.5.5</vulnerable_versions>
<patched_version></patched_version>
<manifest_path>src/java/ws/rest-client/package-lock.json</manifest_path>

https://nvd.nist.gov/vuln/detail/CVE-2025-71330 https://joshua.hu/image-size-infinite-loop-dos-vulnerabilities https://web.archive.org/web/20260224152152/https://github.com/image-size/image-size/pull/439 https://www.vulncheck.com/advisories/image-size-denial-of-service-via-malformed-icns-image-parsing https://github.com/advisories/GHSA-w3rx-r6r6-pgpr

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the update, note them in the PR description so a human reviewer can assess whether they are related.</task_instructions>

  • Resolves NAG-DevOps/splints alert #582

…ndency)

Co-authored-by: smokhov <10067003+smokhov@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix image-size denial of service vulnerability in ICNS parser Fix image-size DoS vulnerability (GHSA-w3rx-r6r6-pgpr) by dropping it via less upgrade Sep 2, 2026
Copilot AI requested a review from smokhov September 2, 2026 01:26
Co-authored-by: smokhov <10067003+smokhov@users.noreply.github.com>
@smokhov
smokhov marked this pull request as ready for review September 2, 2026 01:34
@smokhov
smokhov merged commit 7aae284 into integration Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants