feat: Add setting menu to save patched app crash logs to file#143
Open
prateek-who wants to merge 2 commits intoMorpheApp:devfrom
Open
feat: Add setting menu to save patched app crash logs to file#143prateek-who wants to merge 2 commits intoMorpheApp:devfrom
prateek-who wants to merge 2 commits intoMorpheApp:devfrom
Conversation
Contributor
|
Crashes are captured perfectly. Intentional crash from a bad patching: |
Contributor
Author
|
Is the UI fine for this? Or does it feel confusing or not apparent enough? |
Contributor
|
It works how it is, but it's not a setting. Maybe a second menu can exist for tools. A second button beside settings or something. |
Contributor
|
Unrelated to this, but the patch source title on the main screen could be clickable that opens a drop down menu or a dialog to change the patch source. |
Contributor
Author
|
Yup, working on that right now. Manager does it much better by listing all patchable apps once a source is added, so implementing that first in the gui. Will have to change the cli so that it allows it too after this. |
38d5c83 to
373e19b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.