Improve Roles page UX and app-wide scroll performance - #63
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe roles page now prioritizes direct-report role assignments with per-row saving and progression-aware selections. Catalog and framework tools move into separate sections. Page navigation now follows URL hashes instead of scroll observation. ChangesRoles workflow and navigation
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Put people assignment first on Roles with numbered flow, collapse extract/migrate under Advanced, and fix extract/import API paths. Drop IntersectionObserver scroll-spy and content-visibility so long pages scroll more smoothly app-wide. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
3879b18 to
1f0e5e6
Compare
Summary
Roles previously led with catalog/edit and buried assignment at the bottom, so it was easy to try “add/edit roles” instead of assigning people. This also continues scroll-performance work after #62.
Changes
/api/roles/extractand/api/roles/importwith the correct payload/response shapes.content-visibilityon sections (was causing scroll jumps/jank).Verification
pnpm --filter @prm/ui typecheckpasses.Summary by CodeRabbit
New Features
Improvements