Upgrade React 18 to 19 with matching react-dom and types - #40
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR updates the Loadpath frontend bundle, upgrades React to 19.2.8, changes the HTML entrypoint, and adds ChangesLoadpath frontend
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: ⚪ Minimal · up to This update aligns React, React DOM, and their type packages and refreshes the served assets; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Browser
participant index.html
participant LoadpathBundle
participant LayeredGraph3D
participant Three.jsWebGLRuntime
Browser->>index.html: Load module script
index.html->>LoadpathBundle: Load updated application bundle
LoadpathBundle->>LayeredGraph3D: Render graph component
LayeredGraph3D->>Three.jsWebGLRuntime: Create scene and render graph
Three.jsWebGLRuntime-->>LayeredGraph3D: Render WebGL frame
LayeredGraph3D-->>LoadpathBundle: Report hover or selection event
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Dependabot #36 bumped only react-dom and @types/react-dom, which cannot install: react-dom 19 requires react 19, and @types/react-dom 19 requires @types/react 19. @xyflow/react 12 already accepts React >=17. Rebuild the served static bundle for the new runtime. Co-authored-by: zord.lack.net <zord.lack.net@gmail.com>
7563d8b to
55e62cc
Compare
Dependabot #36 bumped only
react-domand@types/react-dom. That cannot install:react-dom@19requiresreact@19, and@types/react-dom@19requires@types/react@19.This upgrades the React runtime and types together, on top of the Vite 8 toolchain.
@xyflow/react@12already accepts React>=17.Supersedes #36.
Changes
react/react-dom^18.3.1→^19.2.8@types/react^18.3.12→^19.2.18@types/react-dom^18.3.1→^19.2.4src/loadpath/static/for the new runtime (Vite 8 hashes)Impact
createRootand hooks; no classdefaultPropsorReactDOM.rendertscpassed locally on Vite 8 + Vitest 4Test plan
cd ui && npm test(91 tests) after rebase onto Vite 8cd ui && npm run buildtestjob greenSummary by CodeRabbit
New Features
Improvements