Fix selected graph node overflowing horizontally - #12
Merged
Conversation
Long identifiers and file paths in the top-right inspector were treated as unbreakable words, so the card painted past the graph pane. Wrap those strings inside the inspector and ellipsize titles inside the fixed-width graph nodes. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe UI now inserts soft wrap points in graph and inspector text. CSS constrains long content and truncates node titles. Unit, stylesheet, and E2E tests verify wrapping and overflow behavior. Bundled asset references and TypeScript exclusions were updated. ChangesGraph text layout
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…ets. styles.test.ts reads CSS from disk via node:fs, which tsc cannot resolve with the Vite DOM types. Keep tests out of the app compile and ship the overflow CSS in the packaged static bundle. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
overflow-wrap: break-word keeps the top-right inspector inside the graph pane. Zero-width wrap hints after /, _, and . let long names and paths break at readable points instead of mid-token. Co-authored-by: Damon <Modsofthenation@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long identifiers in the selected-node inspector (top-right of the graph) were treated as unbreakable words, so the card painted past the graph pane.
This keeps that inspector inside the pane:
overflow-wrap: break-wordandoverflow-x: hiddenon the inspectormax-width: calc(100% - 24px)so it cannot outgrow the graph/,_, and.so names and paths break at readable pointsTesting
scrollWidth <= clientWidth, bounding box in pane)test_task_definition_file_survives_call_site_placeholderinspector is 260px wide with 12px right gapSummary by CodeRabbit
Bug Fixes
Tests