Advance the MEOS pin to e9883a1e51 - #248
Merged
estebanzimanyi merged 1 commit intoAug 7, 2026
Merged
Conversation
The pin carries the MEOS raster sampling entry points and, with them, four upstream changes the fixtures have to follow. minusStbox returns the complement of the corresponding at restriction, so removing a box that covers [2000-01-01, 2000-01-02] from a three-instant trajectory leaves the fragment after 2000-01-02 rather than nothing. An h3index text literal is hexadecimal, as in h3-pg and in MobilityDB's own 288_th3index_compops test; a numeric cell reaches the type through a bigint cast. A decimal string of more than sixteen digits parses as hexadecimal, overflows and saturates, so every such literal collapses to the same invalid cell and unrelated cells compare equal. pgpointcloud sizes a serialized point as sizeof(SERIALIZED_POINT) - 1 plus the schema point size, and a serialized patch from the buffer-aligned header, both of which reserve bytes past the written content: three for a point (12 - 1 + 24 = 35), fifteen for a patch (64 - 1 - 48 = 15). MEOS emits that reserved tail as zeros, so the literals carry it; without it the tail rule reaches into the last coordinate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advances the pinned MobilityDB commit, which carries the MEOS raster sampling
entry points (
raster_value_gdaland its at/minus/ever/always siblings) and,with them, four upstream changes the fixtures follow.
minusStboxis the complement of the correspondingatrestriction(
080e218bba). Removing a box covering[2000-01-01, 2000-01-02]from athree-instant trajectory leaves the fragment after
2000-01-02.An
h3indextext literal is hexadecimal, as in h3-pg and in MobilityDB's own288_th3index_compopstest, and a numeric cell reaches the type through abigint cast. The fixtures use those two canonical forms. One point for the MEOS
side: a decimal string of more than sixteen digits is also valid hexadecimal, so
stringToH3overflows and saturates toffffffffffffffffwithE_SUCCESS—every such literal is the same invalid cell, and unrelated cells compare equal.
Direct libh3 output:
The pointcloud literals carry their reserved tail (
63f974c5f4,c3a16200c0). pgpointcloud sizes a serialized point assizeof(SERIALIZED_POINT) - 1 + schema point sizeand a serialized patch fromthe buffer-aligned header, both reserving bytes past the written content — three
for a point (12 - 1 + 24 = 35 bytes total), fifteen for a patch
(64 - 1 - 48 = 15). MEOS emits that tail as zeros instead of uninitialized heap.
The fixtures' hand-written literals now include the tail, so the rule stays out
of the last coordinate and every coordinate round-trips.
Full suite green on this commit: 1798 assertions in 77 test cases.