test(insurance): cover reinsurance agreements and recovery path - #1073
Open
Moonwalker-rgb wants to merge 1 commit into
Open
test(insurance): cover reinsurance agreements and recovery path#1073Moonwalker-rgb wants to merge 1 commit into
Moonwalker-rgb wants to merge 1 commit into
Conversation
Pin the reinsurance money path: agreement registration auth, payouts below and exactly at the threshold (no recovery), payouts above the threshold (recovery recorded), and pool behavior when recovery fails (payout from pool capital, or claim rejection when capital is insufficient). Fixes MettaChain#1026.
|
@Moonwalker-rgb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1026
Summary
The reinsurance money path in
contracts/insurancehad no test coverage: agreement registration, threshold crossing, recovery success/failure, and pool behavior when recovery fails were all unpinned.Changes
New tests in
contracts/insurance/src/tests.rscover:amount > threshold).InsufficientPoolFunds) instead of paying out uncovered funds.Registration auth is pinned by the existing
test_register_reinsurance_worksandtest_register_reinsurance_unauthorized_fails.Verification
cargo test -p propchain-insurancepasses (121 tests).