fix(identity): remove no-op cross_contract_helper - #1072
Open
Moonwalker-rgb wants to merge 1 commit into
Open
Conversation
call_contract merely invoked the closure it was given, performing no actual cross-contract call, gas handling, or error translation, and nothing in the crate used it. Remove the dead helper and the module include in dashboard.rs. Fixes MettaChain#1025.
|
@Moonwalker-rgb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1025
Summary
contracts/identity/src/cross_contract_helper.rswas a pass-through:call_contractjust invoked the closure it was given, with no actual cross-contract call, gas handling, or error translation. Nothing incontracts/identity/used it, so it was dead and misleading.Changes
contracts/identity/src/cross_contract_helper.rs.pub mod cross_contract_helperinclude fromcontracts/identity/src/dashboard.rs.Verification
cargo test -p propchain-identitypasses (25 tests).