test(staking): cover non-admin rejection of set_slashing_coordinator - #1070
Open
gbengaeben wants to merge 1 commit into
Open
test(staking): cover non-admin rejection of set_slashing_coordinator#1070gbengaeben wants to merge 1 commit into
gbengaeben wants to merge 1 commit into
Conversation
set_slashing_coordinator was only exercised as the admin in test setup; its admin-gated auth was never asserted. Add a test confirming a non-admin caller is rejected with Unauthorized, and that after the admin sets the coordinator, the coordinator can slash a validator and the slash reduces self-stake. Closes MettaChain#1029
|
@gbengaeben Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The staking slashing-coordinator path had slashing-flow tests, but the admin-gated
set_slashing_coordinatorauth itself was never asserted (see #1029).Changes
set_slashing_coordinator_non_admin_fails: asserts a non-admin caller is rejected withUnauthorized.Verification
cargo test -p stakingpasses (108 tests).Closes #1029