test(mock-oracle): cover non-admin rejection of transfer_admin - #1069
Open
gbengaeben wants to merge 1 commit into
Open
test(mock-oracle): cover non-admin rejection of transfer_admin#1069gbengaeben wants to merge 1 commit into
gbengaeben wants to merge 1 commit into
Conversation
transfer_admin was only tested for the admin success path; the admin-gated rejection was never asserted. Add a test confirming a non-admin caller is rejected with Unauthorized and the admin role is unchanged. Closes MettaChain#1032
|
@gbengaeben Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The mock oracle's admin-transfer path was only tested for the admin success case; the admin-gated rejection was never asserted (see #1032).
Changes
non_admin_cannot_transfer_admin: asserts a non-admin caller is rejected withOracleError::Unauthorizedand that the admin role is unchanged after the rejected call.Verification
cargo test -p mock-oraclepasses (18 tests).Closes #1032