feat(governance): emit PublicKeyRegistered event on public-key registration - #1068
Open
gbengaeben wants to merge 1 commit into
Open
Conversation
…ration register_public_key previously overwrote a signer's stored ECDSA public key without any on-chain traceability. Emit a PublicKeyRegistered event (signer, public key, timestamp) on both registration and overwrite so signer key rotations are observable to auditors and off-chain indexers. Add a unit test asserting the event fires and carries the expected signer, key and timestamp. Closes MettaChain#1031
|
@gbengaeben Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register_public_keysilently overwrote a signer's stored ECDSA public key with no on-chain traceability, making signer key rotation invisible to auditors and off-chain indexers (see #1031).Changes
PublicKeyRegisteredevent carrying thesigner,public_keyand atimestamp.Verification
cargo test -p governancepasses (37 tests).Closes #1031