Repository navigation
Add ChallengeAI federal delivery layer - #28
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a2ca23533
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
added 2 commits
September 1, 2026 15:23
…claims after review - withdraw the all-inputs-sanitized verdict: selectedLibrary bypasses sanitization and is exploitable via crafted share-link URLs (XSS) - correct CSV validation from strict to permissive (text/plain accepted) - account for the Copy Share Link feature moving data outside the browser; flip privacy_assessment_required to true - correct live-preview library architecture: D3/Highcharts/ECharts/ OpenLayers/Leaflet are all CDN-loaded and executed at runtime, not code-generation-only; note the unused d3 npm dependency - stop calling the npm audit check merge-blocking when branch protection is unverified
nniccolb
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CHALLENGEAI.md(index) and.challengeai/(federal-context.md,profile.yml, and the 12challenge-*.mdtool files) documenting this repo's federal-delivery posture.challenge-ato.md/challenge-ui.md:README.md'sSecurity: SOC 2badge links to Netlify's own SOC 2 report, not an audit of this application. TheAccessibility: WCAG 2.1 AAbadge has no automated scan, jsx-a11y lint rule, or measured contrast/reflow check behind it — real ARIA usage exists in 6 components, but "compliant" overstates what's actually verified.challenge-ato.md:SECURITY.mdclaims "Content Security Policy: CSP headers to prevent code injection" — no CSP is configured anywhere (nonetlify.tomlheaders block, no meta tag).challenge-ea.md/challenge-tdd.md: the one real security control this app has — HTML-entity sanitization of user data before it's embedded into generated code (XSS prevention) — is duplicated byte-for-byte in two separate files (BaseGenerator.tsand inline inGenerator.tsx) with zero test coverage on either copy.challenge-cli.md: noAGENTS.md/CLAUDE.mdexists — no runtime entry point for either Claude Code or Codex. Named as a gap, not filled in by this PR.challenge-ci.md— this repo's CI runs a genuinely blockingnpm auditgate (nocontinue-on-error, unlike most sibling repos where dependency scanning is advisory) and a real, passing 16-case test suite.Test plan
.challengeai/files andCHALLENGEAI.mdfor consistency (badge claims, the sanitization-duplication finding, test-coverage figures).