feat(account-tree-controller): add :accountGroup{Created,Updated,Removed}#8766
Merged
Conversation
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
ccharly
force-pushed
the
cc/feat/account-tree-controller-group-events
branch
from
b08a6f4 to
ef5577c
Compare
ccharly
changed the title
:accountGroup{Created,Updated}:accountGroup{Created,Updated,Removed}
danroc
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding similar events than
:multichainAccountGroup{Created,Updated}.Those events will be used by the
SnapAccountService.References
N/A
Checklist
Note
Medium Risk
Adds new post-
initmessenger events and tracking logic around account add/remove and group metadata mutations; risk is mainly around event ordering/duplication and downstream consumers relying on the new signals.Overview
Adds three new messenger events—
AccountTreeController:accountGroupCreated,:accountGroupUpdated, and:accountGroupRemoved—to let consumers react to account-group lifecycle changes afterinit/reinit(no events during initialization).Updates
AccountTreeControllerto track which groups were created/updated/removed duringAccountsController:accountsAddedand:accountsRemovedbatches (avoiding doublecreated+updatedin the same batch), publishes the new events after the existing:accountTreeChange, and emits:accountGroupUpdatedonsetAccountGroupName/setAccountGroupPinned/setAccountGroupHidden.Exports the new event types from
types.ts/index.ts, adds a comprehensive test suite for the new event semantics, and updates the package changelog and eslint suppression counts accordingly.Reviewed by Cursor Bugbot for commit f2ce76b. Bugbot is set up for automated code reviews on this repo. Configure here.