feat(keyring-watch-only): add keyring-watch-only (EVM only) - #644
Merged
Merged
Conversation
ccharly
added this pull request to stack #645
September 30, 2026 12:16
ccharly
changed the title
ccharly
marked this pull request as ready for review
September 30, 2026 12:27
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
force-pushed
the
cc/feat/watch-only-keyring
branch
from
September 30, 2026 19:40
a1e782a to
487a8e0
Compare
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
ccharly
force-pushed
the
cc/feat/watch-only-keyring
branch
from
October 1, 2026 07:41
487a8e0 to
17a6744
Compare
ccharly
commented
Oct 1, 2026
Comment on lines
+363
to
+396
| /** | ||
| * Get an account by its ID, synchronously. | ||
| * | ||
| * @param accountId - The account ID to look up. | ||
| * @returns The account, or `undefined` if not found. | ||
| */ | ||
| lookupAccount(accountId: AccountId): KeyringAccount | undefined { | ||
| return this.#registry.get(accountId); | ||
| } | ||
|
|
||
| /** | ||
| * Get an account by its address (case-insensitive), synchronously. | ||
| * | ||
| * Performs an O(1) exact lookup first; falls back to a linear scan to | ||
| * handle addresses passed with a different casing (e.g. lowercase vs | ||
| * EIP-55 checksummed). All addresses held by the keyring are valid EVM | ||
| * addresses, so the fallback comparison is safe. | ||
| * | ||
| * @param address - The address to look up. | ||
| * @returns The account, or `undefined` if not found. | ||
| */ | ||
| lookupByAddress(address: string): KeyringAccount | undefined { | ||
| const accountId = this.#registry.getAccountId(address); | ||
|
|
||
| if (accountId !== undefined) { | ||
| return this.#registry.get(accountId); | ||
| } | ||
|
|
||
| return this.#registry | ||
| .values() | ||
| .find( | ||
| (account) => account.address.toLowerCase() === address.toLowerCase(), | ||
| ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Mostly added to make the integration easier on the AccountsController.
I plan on using the same pattern than for SnapKeyringV2: https://github.com/MetaMask/core/blob/42a92c3bef4bbf2025d26b45acc4cc068260e668/packages/accounts-controller/src/AccountsController.ts#L903-L950
We would use the account objects from the keyring rather than re-constructing them manually in the controller.
NOTE: That's also used by the v1 adapter too (v1 are still required by the KeyringController for now).
danroc
reviewed
Oct 1, 2026
danroc
reviewed
Oct 1, 2026
danroc
reviewed
Oct 1, 2026
Contributor
Author
|
bugbot review |
danroc
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new watch-only keyring for EVM addresses only for now.