Update filtering for recording layer dropdown#4611
Open
xkello wants to merge 1 commit into
Open
Conversation
📦 Build Artifacts Ready
|
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Layers view already lets a project choose how layers are ordered - alphabetically, or matching the order set up in QGIS (the
Mergin/SortLayersMethod/Methodproject setting). The Choose Active Layer dropdown shown when adding a feature didn't comply to this setting and was always alphabetical, which mismatched the workflow for projects that rely on a deliberate QGIS layer order.Fixes: #4419
What changed
LayerTreeSortFilterModel::onSourceModelInitialized()into a new static helper,LayerTreeSortFilterModel::sortMethod(QgsProject*), so the setting is read from one place instead of being duplicated.RecordingLayersProxyModel::lessThan()to consult that same helper:Alphabetical-> falls back to the existing alphabetical compare (QgsMapLayerProxyModel::lessThan).PreserveQgisOrder-> ranks layers by their position inQgsProject::layerTreeRoot()->findLayerIds(), meaning the real QGIS layer-tree order, since the dropdown's source model (LayersModel) doesn't natively preserve that order the way the Layers tab's source model does.Behaviour