Skip to content

Fix: Update delete button pressed state color to darker rose (#4605)#4607

Open
abhinav-phi wants to merge 1 commit into
MerginMaps:masterfrom
abhinav-phi:fix/issue-4605-delete-button-color
Open

Fix: Update delete button pressed state color to darker rose (#4605)#4607
abhinav-phi wants to merge 1 commit into
MerginMaps:masterfrom
abhinav-phi:fix/issue-4605-delete-button-color

Conversation

@abhinav-phi

Copy link
Copy Markdown

Fixes #4605

What changed:
The delete button on the photo attachment was inheriting the default pale green bgndHoverColor from MMRoundButton on press/hover.

This PR overrides the bgndHoverColor specifically for the delete button in MMFormPhotoViewer.qml. It now uses a 15% darker shade of the button's base negativeColor (Qt.darker(__style.negativeColor, 1.15)).

This ensures the button provides clear visual feedback on tap without turning green, keeping the UI consistent.

@Withalion Withalion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the color fliping the color of icon and background should be enough and it also fits our design doc. You can do the same thing for the draw icon as well

Image

@abhinav-phi

Copy link
Copy Markdown
Author

Instead of changing the color fliping the color of icon and background should be enough and it also fits our design doc. You can do the same thing for the draw icon as well

Image

okayy sure... I will do this by today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete button colour changes to green on tap instead of remaining rose

2 participants