Use fixed pixel distance for line Start and End handles #4544
Open
uclaros wants to merge 5 commits into
Open
Conversation
If geometry is off-screen upon creation, dashed highlights are generated as empty/zero-length. The new CurveRenderer uses the GPU and does not suffer from this bug.
📦 Build Artifacts Ready
|
Withalion
approved these changes
Jul 21, 2026
Withalion
left a comment
Withalion
left a comment
Collaborator
There was a problem hiding this comment.
Looks okay, the test require some changes and rebase will be also necessary for builds to pass
Coverage Report for CI Build 29835285684Warning No base build found for commit Coverage: 59.059%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording map tool Vertices are now re-calculated when the map scale changed.
This allows for line Start and End handles to be rendered at a fixed pixel distance from the start/end of the line.
Also, lays the ground for filtering of segment middle markers based on segment pixel length (not implemented in this PR).
Also fixes the rendering of dashed MMhighlights that are constructed off-screen.
Fixes #2280