Added notification when a project has a newer version available on the server#4386
Added notification when a project has a newer version available on the server#4386gabriel-bolbotina wants to merge 4 commits into
Conversation
Coverage Report for CI Build 29922160615Coverage increased (+0.02%) to 59.061%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions139 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
left a comment
There was a problem hiding this comment.
It will need some more work as mentioned in main.qml. Also I don't really like the visuals of the notification. Why is the text a link? I propose to use the same design as we want to do in filtering notifications (Figma). It would be great to replace the close icon with "sync" button, let's discuss it.
📦 Build Artifacts Ready
|
Withalion
left a comment
There was a problem hiding this comment.
Besides the comments below, the project list shows information that user has "pending changes to synchronise" even though there are no changes done to the project locally, if there is newer version of project available on server. I don't think we want to show that info if there are no local changes.
📦 Build Artifacts Ready
|
342f9c5 to
51d1f82
Compare
📦 Build Artifacts Ready
|
Implemented code findings
51d1f82 to
41196ec
Compare
📦 Build Artifacts Ready
|
Added a function in mergin api that checks if the project needs a sync and fires a notification in case it is needed.
Tested to work for the currently open project and when switching from one project to another
Use case below:
https://github.com/user-attachments/assets/e0c01bec-5a55-4e22-82a4-2a50c673825b