fix(utils): preserve sign in formatCurrency for negative figures (#90) - #96
Open
ghzhost wants to merge 1 commit into
Open
fix(utils): preserve sign in formatCurrency for negative figures (#90)#96ghzhost wants to merge 1 commit into
ghzhost wants to merge 1 commit into
Conversation
…geFi#90) - remove unconditional Math.abs() in formatCurrency - align behavior with StatCard currency formatting to preserve negative signs - add unit test coverage in utils.test.ts
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #90
Problem
formatCurrencyunconditionally appliedMath.abs(amount), silently stripping the minus sign on negative figures (e.g.formatCurrency(-50)produced"50 USDC"). This contradictedStatCard's currency formatting which preserves negative signs.Solution
Math.abs(amount)fromformatCurrencyinsrc/lib/utils.ts.amount.toLocaleString("en-US", { maximumFractionDigits: 2 }).src/lib/utils.test.tsverifying positive, negative, XLM, and non-finite inputs.Verification
npx jest src/lib/utils.test.tspassed (all 4 tests green).