Skip to content

Fix zero amount rendering in activity feed - #93

Open
eliolewis77 wants to merge 1 commit into
MergeFi:mainfrom
eliolewis77:fix/activity-zero-amount-rendering
Open

Fix zero amount rendering in activity feed#93
eliolewis77 wants to merge 1 commit into
MergeFi:mainfrom
eliolewis77:fix/activity-zero-amount-rendering

Conversation

@eliolewis77

Copy link
Copy Markdown

Summary

  • render activity amounts when amount is explicitly numeric, including 0
  • replace the landing page duplicate activity markup with the shared ActivityList component
  • add ActivityList coverage for zero, undefined, and positive amounts
  • add ts-node as a dev dependency so the existing TypeScript Jest config can be loaded by npm test

Fixes #87

Behavior

I chose to render amount: 0 as formatted currency (0 USDC) because zero is a valid amount distinct from undefined, which remains the no-amount case.

Validation

  • npm test -- --runInBand --no-watchman
  • npm run lint
  • git diff --check

NEXT_PUBLIC_STELLAR_NETWORK=TESTNET npm run build is still blocked on existing main issues unrelated to this PR: duplicate validateTeamSplits exports in src/lib/utils.ts, plus Google Fonts fetch failures in this sandboxed environment.

@vercel

vercel Bot commented Aug 16, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the falsy-zero {event.amount && ...} rendering bug duplicated in ActivityList and HomePage

1 participant