fix: snapshot fee_bps at deposit time to prevent retroactive fee changes - #64
Open
Ugooweb wants to merge 2 commits into
Open
fix: snapshot fee_bps at deposit time to prevent retroactive fee changes#64Ugooweb wants to merge 2 commits into
Ugooweb wants to merge 2 commits into
Conversation
|
@Ugooweb is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
ci test failed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #53
Fixes a potential bait-and-switch bug where
fee_bpswas fetched at payout time instead of deposit time. With the introduction of mutable fees (issue #20), this would have caused sponsors to retroactively pay a different fee rate than they agreed to.fee_bpssnapshotting duringfund/create_milestone. The payout calculations now rely on this captured value. Added tests simulating an interim fee hike to verify the original rate is honored.This PR is coordinated to land prior to or alongside #20 to prevent a window of exploitability in production.