Repository navigation
Code Quality: Isolate remaining Windows-only code (P4 orphans) - #72
Merged
Merged
Conversation
Move RemovableDevice, SyncRootHelpers (with a Linux stub) and the Win32 breadcrumb subfolder enumeration into *.Windows.cs files. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves orphaned Windows-only code out of the shared build: RemovableDevice.Windows.cs, SyncRootHelpers.Windows.cs (+ Linux stub returning no quota), NavigationToolbarViewModel.Windows.cs (Win32 FindFirstFileEx subfolder listing, call site guarded by #if WINDOWS).
Desktop build and Files.Platform.Tests pass. Compat-off: fixes RemovableDevice (2 keys), SyncRootHelpers (1), NavigationToolbarViewModel (1), plus FileOperationsHelpers/FilesystemHelpers keys already resolved on main. Baseline not ratcheted: 3 keys in WP-owned files (WidgetFolderCardItem, FolderSearch, QuickAccessWidgetViewModel) are not in the baseline.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY