Fix: Toolbar row missing on Linux - #71
Merged
Merged
Conversation
Upstream sync (#63) moved FindName for the toolbar, tab bar and nav toolbar into the MainPage constructor. On Uno the x:Bind bindings of those controls are not initialized that early, so the toolbar row never showed. Keep the constructor path on Windows and use Page_Loaded elsewhere. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression from the upstream sync (#63, fbed5eb; upstream files-community#19002 'Improved startup performance'), which moved
FindNameforInnerNavigationToolbar,TabControlandNavToolbarinto theMainPageconstructor. On Uno the x:Bind bindings of those x:Load controls are not initialized that early, so the New/sort/group/layout/preview-pane row was never drawn. Windows keeps the constructor path; other platforms realize them inPage_Loaded.Bisect: #59 and #60 render the toolbar, #63 does not. Verified headlessly (Documents shows the toolbar; layout switch to Grid via toolbar works). Platform tests: 838 passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY