Repository navigation
Code Quality: Previews and leaf storage users on storables (P4-G) - #70
Merged
Merged
Conversation
ListedItem.ItemFile is IFile? on desktop, previews resolve files through IStorableResolver and keep the O_PATH/stat-before-open PreviewFile.OpenRead hardening for local files. Shortcut items use ShowWindowCommand; Windows-only preview and helper code moved to *.Windows.cs. Compat-off baseline ratcheted. Co-Authored-By: GPT-6.1-sol (OpenAI Codex) <noreply@openai.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
…locks Co-Authored-By: GPT-6.1-sol (OpenAI Codex) <noreply@openai.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
Co-Authored-By: GPT-6.1-sol (OpenAI Codex) <noreply@openai.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ListedItem.ItemFile/IListedItem.ItemFileareIFile?on desktop (BaseStorageFile?on Windows); no binding-visible member changes.IStorableResolver; local files keep thePreviewFile.OpenReadO_PATH/stat-before-open hardening. Folder, text, image, media-metadata and archive previews updated.ShowWindowCommand(noSHOW_WINDOW_CMDcasts);ShowWindowCommandExtensionsis now Win32-free (int based) and used by the enumerators/FolderSearch.IStorableResolver; Git service no longer needsShellStorageFolder.*.Windows.cs(FTPToStorageItem, Share/Transfer helpers, Code/Markdown/Shell/Text previews, BasePreviewModel).LINUX-TODOstubs on desktop (their controls still compile).Behaviour change
On desktop, copy/cut in
TransferHelpersnow also publishes the paths to the system clipboard throughDesktopFileDragHelper.PublishFilesAsync; a failure there is logged and does not fail the action.Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY