Repository navigation
Code Quality: Resolver-based storage helpers; isolate Windows enumeration and search (P4-C) - #67
Merged
Merged
Conversation
…lated (P4-C) Co-Authored-By: GPT-6.1-sol (OpenAI Codex) <noreply@openai.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
Apply upstream v4.2.38 search performance changes (files-community#18992): shared batching, shortcut and icon finalization in FolderSearch.cs, Win32 walk in FolderSearch.Windows.cs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
…der wrappers on Linux Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
…op .Windows suffix on wrappers Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 work package P4-C: resolver-based storage helpers, with Windows-only enumeration and search code moved into
*.Windows.cspartials (FolderSearch.Windows.cs etc.).Implemented by OpenAI Codex (GPT-6.1-sol). The merge with linux/main (upstream v4.2.38 search performance, files-community#18992) was resolved by Claude: shared batching (
AddResult,SearchTickasEventHandler<IReadOnlyList<ListedItem>>), shortcut/icon finalization stay in FolderSearch.cs; the Win32 walk, indexed-state check and storage-query changes live in FolderSearch.Windows.cs.Verification:
dotnet build src/Files.App -f net10.0-desktopsucceeds; Files.Platform.Tests 838 passed, 7 skipped, 0 failed. compat-off-check reports 2 new keys (WidgetFolderCardItem.cs, QuickAccessWidgetViewModel.cs: WinRT/IAgileReference, from the upstream sync); baseline not updated. Windows build not verified.🤖 Generated with Claude Code
https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY