Code Quality: Follow-ups from grouped virtualization and service menu reviews - #100
Merged
Merged
Conversation
Clamp the placeholder line index, reset anchor restore when the ScrollViewer is gone, reject control characters hidden by padded group headers, and update the launching threat model row. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from reviews of #96 and #99.
\v[Foo],[Foo]\f) inside [Desktop Entry] are rejected. Added DataRows.No unit test was added for deletion while scrolled to the end: the Uno panel is not unit-testable here.
Tests: Files.Platform.Tests 991 total, 984 passed, 0 failed, 7 skipped. Files.App (net10.0-desktop) builds with 0 errors.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LeKXJc3DnK3PzAqwgA72NY