Skip to content

Optimize command lowercasing in ZCommandManager and cooldown lookup in ZUser #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maxlego08 merged 1 commit into from
Sep 19, 2026
Merged

Optimize command lowercasing in ZCommandManager and cooldown lookup in ZUser #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/main/java/fr/maxlego08/essentials/commands/ZCommandManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,14 @@ public void registerCommand(String string, EssentialsCommand command) {

@Override
public boolean onCommand(@NotNull CommandSender sender, @NotNull Command cmd, @NotNull String label, String[] args) {
final String commandName = cmd.getName().toLowerCase(java.util.Locale.ROOT);
for (EssentialsCommand command : this.commands) {
if (command.getSubCommands().contains(cmd.getName().toLowerCase())) {
if (command.getSubCommands().contains(commandName)) {
if ((args.length == 0 || command.isIgnoreParent()) && command.getParent() == null) {
CommandResultType type = processRequirements(command, sender, args);
if (!type.equals(CommandResultType.CONTINUE)) return true;
}
} else if (args.length >= 1 && command.getParent() != null && canExecute(args, cmd.getName().toLowerCase(), command)) {
} else if (args.length >= 1 && command.getParent() != null && canExecute(args, commandName, command)) {
CommandResultType type = processRequirements(command, sender, args);
if (!type.equals(CommandResultType.CONTINUE)) return true;
}
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/fr/maxlego08/essentials/user/ZUser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ public void setCooldownSilent(String key, long expiredAt) {

@Override
public boolean isCooldown(String key) {
return this.cooldowns.containsKey(key) && this.cooldowns.get(key) >= System.currentTimeMillis();
Long cooldown = this.cooldowns.get(key);
return cooldown != null && cooldown >= System.currentTimeMillis();
}

@Override
Expand Down
Loading