MDEV-37335: crash on re-parsing an sp_instr_set that does not own its LEX - #5643
Open
KhaledR57 wants to merge 1 commit into
Open
MDEV-37335: crash on re-parsing an sp_instr_set that does not own its LEX#5643KhaledR57 wants to merge 1 commit into
KhaledR57 wants to merge 1 commit into
Conversation
… LEX A DECLARE of several variables with a common DEFAULT expression creates one sp_instr_set per variable, all sharing a single LEX that only the last of them owns. On re-parsing after a metadata change, a non-owning instruction still has its LEX, and both parse_expr() and validate_lex_and_exec_core() took a non-null LEX to mean a cursor LEX. The cursor-only code then dereferenced the nullptr returned by get_lex_for_cursor() and the re-parsed LEX was never adopted. Branch on whether the LEX is a cursor LEX instead of whether it is non-null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DECLARE of several variables with a common
DEFAULTexpression creates onesp_instr_setper variable, all sharing a single LEX that only the last of them owns. On re-parsing after a metadata change, a non-owning instruction still has its LEX, and bothparse_expr()andvalidate_lex_and_exec_core()took a non-null LEX to mean a cursor LEX. The cursor-only code then dereferenced the nullptr returned byget_lex_for_cursor()and the re-parsed LEX was never adopted.Branch on whether the LEX is a cursor LEX instead of whether it is non-null.