fix: default configManagement.offlineMode to true (MAPCO-8284)#108
Closed
roicohen326 wants to merge 1 commit into
Closed
fix: default configManagement.offlineMode to true (MAPCO-8284)#108roicohen326 wants to merge 1 commit into
roicohen326 wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing — this was based on a misread of what was needed. helm-charts already has the correct configManagement.offlineMode override in place for all environments; this chart-default change isn't necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every consumer of this chart in helm-charts (dev/qa/integration, ingestion-trigger, raster-catalog-manager too) has had to manually override `configManagement.offlineMode: false → true`. The shipped default of `false` points at `serverUrl: http://localhost:8080/api\` — a config server that doesn't exist in any of our current environments, so leaving the default unset risks the app trying to fetch remote config on startup and hanging.
Flips the chart's own default to the safe value so umbrella charts don't have to keep rediscovering and overriding this.
No other configManagement fields touched.