Skip to content

docs(issues): own gap inventory, split into fix vs add - #71

Merged
ManSio merged 1 commit into
mainfrom
chore/gap-inventory-2026-10-04
Oct 4, 2026
Merged

ManSio merged 1 commit into
mainfrom
chore/gap-inventory-2026-10-04

Conversation

@ManSio

@ManSio ManSio commented Oct 4, 2026

Copy link
Copy Markdown
Owner

What

A dry, self-referential gap inventory appended to ISSUE.md. No external attribution: every referent is internal (file:line), every number comes from a command run in this repo.

Twenty items, split into F — fix what is ours and A — add what we do not have at all, plus an explicit list of things not to adopt.

Why these twenty

The list came from measuring this repo against itself rather than against a wish list: which gates are wired into nothing, which numbers in the docs cannot be produced by today's command, which guards are red, and which affordances exist only as prose.

The seven that matter most

Item Evidence
1 F5 — the protocol guard is red: exit 1, 7 findings (6 rate tools without an empty-population refusal, 1 frozen artifact without sha256), and it is in neither CI nor pre-commit. check_t10/check_t11 have no test assertion at all scripts/audit_protocol_guards.py:66,87-98
2 F6 — three confirmed doc/code drifts: 31/64 vs actual 32/65 tools; 8 documented pre-commit checks vs 11 invoked; a published "8 reported, 62.5% false positives" against a current 7 server_tools.py:6,10 · .githooks/pre-commit:8-16 · run_all.py:71-73
3 F1 — the only item that hits the agent user rather than us: no typed degraded states, so "0 results" and "could not check" return the same value search_tools.py:197,607
4 F2a — no exact runtime guard on the MCP surface; the only exact one sits behind importorskip, the other counts text test_mcp_schema_flat.py:38 · auto_doc_updater.py:459
5 F4 — run_all.py, the "prove every guard can fail" suite, is opt-in tools/verification/run_all.py
6 F8 — no CI job fails when a lane is flaky or cancelled .github/workflows/ci.yml
7 A3 — the frozen-manifest mechanism exists; the requirement for hard negatives does not frozen_overlap_check.py

Deliberately not adopted

Recorded in the file so nobody re-litigates it: shrinking 65 tools to 8 mega-tools (size is not protection without a discriminator guard), a JSON vector store with a lexical prefilter (we are already on LanceDB with an IVF guard), and an offline memory harness with no production caller.

Verification

  • 57 insertions, 0 deletions — purely additive.
  • Full pre-commit set green (fast mode, gate-zero deferred to CI as documented).

Not verified: nothing in this PR is executable code, so there is nothing to run. The claims are read-level claims about the current tree and are falsifiable by the referenced file:line.

Twenty items, each with an internal file:line referent and a measured
number, sorted by cost/benefit rather than by importance.

F (fix): the product returns no typed degraded states, so an empty result is
indistinguishable from a failed check (F1); there is no exact runtime guard on
the MCP surface, only a floor that importorskip can remove (F2a); seven names
in the write-annotation set are never registered (F2b); the layer bucket
labelled transitional cannot block and has no expiry (F3); the suite that
proves every guard can fail is wired into neither CI nor pre-commit (F4); the
protocol guard is currently red with seven findings and unmonitored (F5);
three confirmed doc/code drifts (F6).

A (add): per-row freshness proof at the retrieval boundary (A1); generated
agent prompt with a build hash (A2); hard negatives required by the frozen
manifest schema (A3); schema snapshot for action discriminators (A4); a
counter for the line-based parser fallback, which is currently unmeasured
(A5); fail-closed behaviour when the project root is unset (A6); one recorded
mutmut run (A7).

Also records what not to adopt: shrinking to 8 mega-tools, a JSON vector
store with a lexical prefilter, and an offline memory harness with no
production consumer - all three are regressions against what we already have.
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d2801469-dd78-4682-b302-87999656225e
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit 5612375 into main Oct 4, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant