Skip to content

docs(known-issues): record the PATH-dependent bash resolver defect - #69

Merged
ManSio merged 1 commit into
mainfrom
chore/record-gate-fixes
Oct 3, 2026
Merged

ManSio merged 1 commit into
mainfrom
chore/record-gate-fixes

Conversation

@ManSio

@ManSio ManSio commented Oct 3, 2026

Copy link
Copy Markdown
Owner

Registry entry for a defect found and fixed while unblocking PR #67.


egative_controls_runner._resolve_bash()\ resolved bash only through \shutil.which. From an agent shell the Git bin directory is absent from PATH, so the lookup returned the WSL shim \C:\WINDOWS\system32\bash.exe, which the resolver correctly rejected -> \None. GitBash was installed the whole time at \C:\Program Files\Git\bin\bash.exe.

Effect: \drift_gate\ reported [BROKEN], the negative-controls gate returned \FAILED (broken=1), and all 11 pre-commit gates blocked every commit.

Fix (already on main via #67, commit d43b9e5): also probe the standard Git install roots and the root implied by \git\ on PATH; the WSL shim is still rejected. \drift_gate\ is now [PROVEN], inventory reports \ALL PROVEN (3), rc=0, and the full hook passes.

Same class as the earlier 'gate unusable outside the author's folder' entry: state that depends on the launching shell.

negative_controls_runner resolved bash only via shutil.which. From an agent shell Git's bin dir is absent from PATH, so the WSL shim won the lookup and the resolver returned None, marking drift_gate BROKEN and blocking every commit. GitBash was installed all along.
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 511acaee-5926-448c-bb67-00f19b36e806
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ManSio
ManSio merged commit 1d21a2c into main Oct 3, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant