docs(known-issues): record the PATH-dependent bash resolver defect - #69
Merged
Merged
Conversation
negative_controls_runner resolved bash only via shutil.which. From an agent shell Git's bin dir is absent from PATH, so the WSL shim won the lookup and the resolver returned None, marking drift_gate BROKEN and blocking every commit. GitBash was installed all along.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registry entry for a defect found and fixed while unblocking PR #67.
egative_controls_runner._resolve_bash()\ resolved bash only through \shutil.which. From an agent shell the Git bin directory is absent from PATH, so the lookup returned the WSL shim \C:\WINDOWS\system32\bash.exe, which the resolver correctly rejected -> \None. GitBash was installed the whole time at \C:\Program Files\Git\bin\bash.exe.
Effect: \drift_gate\ reported [BROKEN], the negative-controls gate returned \FAILED (broken=1), and all 11 pre-commit gates blocked every commit.
Fix (already on main via #67, commit d43b9e5): also probe the standard Git install roots and the root implied by \git\ on PATH; the WSL shim is still rejected. \drift_gate\ is now [PROVEN], inventory reports \ALL PROVEN (3), rc=0, and the full hook passes.
Same class as the earlier 'gate unusable outside the author's folder' entry: state that depends on the launching shell.