Update Dockerfile and docs - #261
Conversation
lecriste
added
bug
|
@maryapp, I noticed you just restructured the docs - thank you! I would still keep the jupyter-notebook sub-section though, I found it useful. |
|
@lecriste there is a docker notebook sub-section; I guess the goal is to switch to docker, and keep conda optional (very optional). But yes, you are welcomed to add anything you consider useful!! |
e85cd11 to
5586fe6
Compare
There was a problem hiding this comment.
Pull request overview
This PR resolves a Docker build failure by updating an obsolete package dependency and enhances documentation with explicit setup instructions for remote database access via Jupyter Notebook.
Changes:
- Fixed package name from
umaptoumap-learnin Dockerfile dependencies - Added default values for Docker build arguments to support CI workflows
- Created GitHub Actions workflow to validate Docker builds
- Expanded README with step-by-step Jupyter Notebook setup instructions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dj_pipeline/Dockerfile | Updated obsolete package name and added default build argument values for CI compatibility |
| dj_pipeline/README.md | Added comprehensive Jupyter Notebook setup guide with exact installation commands |
| .github/workflows/docker-build.yml | New CI workflow to automatically test Docker image builds |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1 +1 @@ | |||
| FROM deeplabcut/deeplabcut:2.3.5-core-cuda11.7.1-cudnn8-runtime-ubuntu20.04-latest | |||
There was a problem hiding this comment.
@lecriste, I'm thinking now... maybe we want dlc 3 for this one (for the newer version)
There was a problem hiding this comment.
Yes, it's coming along with the migration PR:
a3e7099#diff-8c59f87a2ad20469e89ead472b2a4714dcce03631d983387812292af6b244d10R1
There was a problem hiding this comment.
@lecriste I would still keep the version (not latest)
There was a problem hiding this comment.
OK, let's follow up here:
a3e7099#r176590225
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: mary <43879378+maryapp@users.noreply.github.com>
This PR updates an obsolete package in
dj_pipeline/Dockerfilethat was causing the build to fail, and expands the docs with the exact copy-and-paste commands needed.It only affects the sections I’ve finished testing; additional updates (e.g. in the
Makefile) will follow in a separate PR.A few wording tweaks in the docs came from a ChatGPT review, I wouldn’t have been so picky myself :)