fix: correct internal spelling typos#1516
Closed
lb1192176991-lab wants to merge 1 commit into
Closed
Conversation
- BC_SlIP_WALL → BC_SLIP_WALL (lowercase 'l' typo, Fortran is case-insensitive so it compiled, but grep missed this site) - lb → lB (lowercase 'l' vs uppercase 'B' consistency in m_finite_differences.fpp allocate) - fite_path_dest → file_path_dest (typo in variable name) Fixes MFlowCode#1498 (partial — items 2, 4, 5).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
=======================================
Coverage 60.64% 60.64%
=======================================
Files 73 73
Lines 20213 20213
Branches 2936 2936
=======================================
Hits 12259 12259
Misses 5966 5966
Partials 1988 1988 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes three spelling typos in the codebase:
BC_SlIP_WALL→BC_SLIP_WALLinsrc/common/m_boundary_common.fpp:263— lowercaselinstead ofLinSlIP. Fortran is case-insensitive so it compiled, but a grep forBC_SLIP_WALLwould miss this site.lb→lBinsrc/common/m_finite_differences.fpp:42— declared everywhere else aslB; this single site used lowercase.fite_path_dest→file_path_destintoolchain/mfc/test/case.py:482,487— clear naming typo in variable name.Why
Spelling errors in identifiers degrade grep-ability and code readability even when they compile (Fortran case-insensitivity).
Testing
All changes are cosmetic identifier renames. No behavior change.
Fixes #1498 (items 2, 4, 5).