feat(skills): support version: latest - #101
Merged
Merged
Conversation
albertodebortoli
changed the title
version: latest
albertodebortoli
force-pushed
the
yaml-format-error-reporting
branch
from
July 22, 2026 12:19
7649464 to
2b4b53a
Compare
Read stdout via a blocking readDataToEndOfFile() on a background queue instead of accumulating chunks from a readability handler behind a lock. readDataToEndOfFile() already drains the pipe continuously as the child writes, so it can't deadlock on a full buffer — no shared mutable state means no lock is needed at all. Mirrors the pattern Unarchiver already uses elsewhere in this codebase.
albertodebortoli
force-pushed
the
support-for-latest
branch
from
July 22, 2026 12:34
c8226cb to
4b9743e
Compare
albertodebortoli
changed the title
version: latestversion: latest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
version: lateston skills (Lucafileskills:/repos:entries andluca install --ref latest). It resolves to the repository's current default-branch HEAD commit viagit ls-remoteinsideSkillsInfoFactory, before the value ever becomes aSkillSet.version— so the cache path, symlinking, andgit checkoutlogic downstream are completely unchanged, since they already treat version as an opaque resolved string.tools:) have a literal, fully-formedurl:with no version templating anywhere in the codebase, solatesthas nothing to attach to for them; that's a separate, larger design question (URL templating or an org/repo-based schema) deferred for now.latestprevents leveraging the cache the way a pinned tag/SHA does. Every install withversion: latestrequires a network round-trip (git ls-remote) to determine the current HEAD commit before Luca can even check whether that commit is already cached — unlike a pinned version, which never needs to contact the remote once its folder exists on disk. The download itself is still skipped if the resolved SHA happens to match a previously cached one, but the "no network needed at all" fast path is gone. It's also not reproducible across time: two installs can resolve to different commits, and therefore install different content, if the upstream repository gains commits in between.SkillLatestVersionResolver(runsgit ls-remote --quiet <url> HEAD, parses the SHA) and a smallSubprocessOutputRunning/SubprocessOutputRunnerprimitive for output-capturing subprocess execution (distinct from the existing exit-code-onlySubprocessRunning, which is left untouched). ExtractedGitRepositoryURLNormalizerout ofGitRepositorySkillFetcherso both it and the new resolver share one URL-normalization implementation.Type of Change
How Has This Been Tested?
Checklist
CI Considerations
Breaking Changes?