fix(http): HTTPClient unusable out of the box (hardcoded http2=True) - #19
Merged
Conversation
connect() passed http2=True unconditionally to httpx.AsyncClient(...), which raises ImportError unless the optional 'h2' package is installed -- never declared as a velocix dependency anywhere (pyproject.toml or requirements.txt only ever list httpx). Every HTTPClient() call, even a trivial GET, crashed for anyone who only installed velocix's own declared dependencies. Found while building a real app that fetches a file by URL. Made http2 a constructor param defaulting to False (httpx's own default), so the common case works with just httpx installed; anyone who wants HTTP/2 can opt in and install h2 themselves. Added tests/test_http_client.py -- this class had zero test coverage before. 260/260 tests, mypy clean, ruff clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while building a real app that fetches a file by URL. connect() passed http2=True unconditionally to httpx.AsyncClient(...), which raises ImportError unless the optional 'h2' package is installed — never declared as a velocix dependency anywhere. Every HTTPClient() call, even a trivial GET, crashed for anyone who only installed velocix's declared requirements.
Made http2 a constructor param defaulting to False (httpx's own default). Added tests/test_http_client.py — this class had zero coverage before. 260/260 tests, mypy clean, ruff clean.